updates no data received message #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not show station active message when no date range is selected - In cases where user requests data from before a station existed, show station inactive warning
bacalj
commented
Jul 23, 2024
| } | ||
| // if the start date of the weather station is after the user's requested end date, then the station is inactive | ||
| const stationMinDate = new Date(weatherStation?.mindate || globalMinDate); | ||
| const stationNotActiveYet = stationMinDate > maxDate; |
There was a problem hiding this comment.
Note on date range checks:
We currently only check if the station's start date is after the user's end date. We don't check the opposite (station's end date before user's start date) because our source data's end dates are not up-to-date (see note in PT-187533021) Implementing the opposite check could therefore result in false negatives for active stations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second PR (in addition to #74 ) that partially addresses issues described in PT-187533021 and PT-187569691
Updated and added some status update messages and logic:
Demo: https://codap.concord.org/releases/latest/static/dg/en/cert/index.html?di=https://models-resources.concord.org/noaa-codap-plugin/branch/station-message